feat: add obligations #150
Conversation
Summary of ChangesHello @alkalescent, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces foundational documentation for 'Obligations,' a new policy construct designed to enable conditional access enforcement at the Policy Enforcement Point (PEP) level. The added content clarifies the purpose, composition, and various types of obligations, providing a clear understanding of how they extend beyond basic attribute-based access control (ABAC) to enforce additional restrictions and requirements. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces documentation for 'Obligations', a key concept in the platform's policy framework. The new document is well-structured and provides a good overview. I've added a couple of suggestions to improve clarity and consistency within the new file. One comment addresses a potentially confusing statement about how obligations are enforced, clarifying the roles of the PDP and PEP. The other comment suggests a formatting change for the use case examples to make them more consistent with the rest of the document. Additionally, you might consider adding 'Obligations' to the list of policy components in docs/components/policy/index.md to make the documentation more discoverable.
jp-ayyappan
left a comment
jp-ayyappan
left a comment
There was a problem hiding this comment.
See comments, let chat if needed
Co-authored-by: Jp Ayyappan <[email protected]>
Co-authored-by: Jp Ayyappan <[email protected]>
Co-authored-by: Jp Ayyappan <[email protected]>
Co-authored-by: Jp Ayyappan <[email protected]>
Co-authored-by: Jake Van Vorhis <[email protected]>
No description provided.